build(deps): bump craft-parts #5031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hotfix/8.3 #5031 +/- ##
=============================================
Coverage ? 89.66%
=============================================
Files ? 335
Lines ? 22488
Branches ? 0
=============================================
Hits ? 20164
Misses ? 2324
Partials ? 0 ☔ View full report in Codecov by Sentry. |
tigarmo
force-pushed
the
work/npm-plugin-fix
branch
3 times, most recently
from
578154e
to
d9b253e
Compare
4 tasks
This new version fixes a bug on the npm plugin. The bug is caused by the plugin having state that implicitly needs to be passed from the 'pull' step to the 'build' step. If both are done in a single Snapcraft 'run', then it works fine; however, running first 'pull' and then 'build' separately trigger the issue - a failure on the build step. Ref: canonical/craft-parts#844
tigarmo
force-pushed
the
work/npm-plugin-fix
branch
from
d9b253e
to
13e0f0a
Compare
cmatsuoka
approved these changes
Sep 13, 2024
tigarmo
changed the title
mr-cal
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new version fixes a bug on the npm plugin. The bug is caused by the plugin
having state that implicitly needs to be passed from the 'pull' step to the
'build' step. If both are done in a single Snapcraft 'run', then it works fine;
however, running first 'pull' and then 'build' separately trigger the issue -
a failure on the build step.
Ref: canonical/craft-parts#844